This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(changelog): add deprecation notice #15441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So we did something strange with this. We deprecated the methods and removed their docs, which I think only adds to the confusion. Imo, ww should also re-add the docs, but give the methods the |
- Add deprecation notice for `angular.lowercase` and `angular.uppercase`
wesleycho
force-pushed
the
docs/string-func
branch
from
0dbf7dc to
da2c349
Compare
|
Can we add the deprecation and removal versions to the deprecation notice? |
|
I can do that. to be removed in 1.7? |
|
Yep - although I think we will need to leave the functions in-place internally. |
|
@petebacondarwin as long as they're not exposed, it doesn't matter. Once we no longer need them, we can remove them then even in a patch release. |
|
Yes, we use them internally. So we should remove them from the public angular object in 1.7 |
Narretz
pushed a commit
that referenced
this pull request
Nov 28, 2016
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
angular.lowercaseandangular.uppercaseThis should address #14316